Machop locations — where to catch

In Lumiose City (Legends: Z-A)

• Wild Zone 12 — Walk
• Wild Zone 8 — Walk

In Hisui (Legends: Arceus)

• Arena's Approach — Walk
• Bolderoll Ravine — Walk
• Castaway Shore — Walk
• Cloudcap Pass — Walk
• Ginkgo Landing — Walk
• Icebound Falls — Walk
• Obsidian Falls — Walk
• Oreburrow Tunnel — Walk
• Snowfall Hot Spring — Walk

In Sinnoh (Diamond, Pearl & Platinum)

• Mt. Coronet — Walk
• Route 206 — Walk
• Route 207 — Walk
• Route 208 — Walk
• Route 210 — Walk
• Route 211 — Walk

In Johto & Kanto (HeartGold & SoulSilver)

• Cliff Cave — Walk
• Johto Safari Zone — Walk
• Mt. Mortar — Walk
• Rock Tunnel — Walk
• Route 47 — Walk

In Hoenn (Ruby, Sapphire & Emerald)

• Fiery Path — Walk
• Jagged Pass — Walk
• Route 112 — Walk

In Kanto (FireRed & LeafGreen)

• Rock Tunnel — Walk

In Sevii Islands (FireRed & LeafGreen)

• Mt. Ember — Walk

In Johto & Kanto (Gold, Silver & Crystal)

• Mt. Mortar — Walk
• Rock Tunnel — Walk

In Kanto (Red, Blue & Yellow)

• Rock Tunnel — Walk
• Route 10 — Walk
• Victory Road — Walk

Other games (8)

• Brilliant Diamond / Shining Pearl (Gen 8): Route 207, Route 208, Route 210
• Sword / Shield (Gen 8): Dusty Bowl, Route 3, Galar Route 3, Giant's Mirror, Giant's Seat, North Lake Miloch, Rolling Fields, South Lake Miloch, Stony Wilderness, Watchtower Ruins
• Let's Go, Pikachu! / Let's Go, Eevee! (Gen 7): Kanto Victory Road 1, Rock Tunnel
• Ultra Sun / Ultra Moon (Gen 7): Ten Carat Hill
• Sun / Moon (Gen 7): Alola Route 2, Ten Carat Hill
• Omega Ruby / Alpha Sapphire (Gen 6): Fiery Path, Hoenn Route 112, Jagged Pass
• X / Y (Gen 6): Glittering Cave
• Black / White (Gen 5): White Forest

Machop — full Pokédex entry