Pupitar locations — where to catch

In Paldea (Scarlet & Violet)

• Alfornada Cavern — Walk
• South Province (Area Six) — Walk

In Johto & Kanto (HeartGold & SoulSilver)

• Mt. Silver — Walk
• Mt. Silver Cave — Walk

In Johto & Kanto (Gold, Silver & Crystal)

• Mt. Silver — Walk
• Mt. Silver Cave — Walk

Other games (4)

• Sword / Shield (Gen 8): Giant's Seat, Lake of Outrage, Rolling Fields, Stony Wilderness
• X / Y (Gen 6): Friend Safari, Kalos Route 18, Terminus Cave
• Black 2 / White 2 (Gen 5): Unova Route 15
• Black / White (Gen 5): Unova Route 15

Pupitar — full Pokédex entry